Re: [coreboot] [PATCH] romcc --include=settings.h support

[Stefan Reinauer]

On 03.04.2009 15:42 Uhr, Peter Stuge wrote:
> Stefan Reinauer wrote:
> > +++ util/romcc/romcc.c	(working copy)
> > @@ -24998,7 +24998,10 @@
> >    /* Enter the globl definition scope */
> >    start_scope(&state);
> >    register_builtins(&state);
> > compile_file(&state, filename, 1);
> > if (includefile)
> > compile_file(&state, includefile, 1);
>
> Shouldn't the include be compiled before the actual file?

Yes, but romcc seems to parse it the other way round. My tests showed
the above produces correct results, while turning the statements around
does not (the first version of my patch looked that way)

Stefan