Re: [LinuxBIOS] flashrom: mcp55 enable bit comment wrong?

[Ed Swierk]

On 8/1/07, Carl-Daniel Hailfinger  wrote:
> Hi,
> > static int enable_flash_mcp55(struct pci_dev *dev, char *name)
> > {
> >         unsigned char old, new, byte;
> >         unsigned short word;
> >     /* Set the 4MB enable bit bit */
>
> wrong comment, probably copy-pasted?
> >     byte = pci_read_byte(dev, 0x88);
> >     byte |= 0xff;           /* 256K */
> >     pci_write_byte(dev, 0x88, byte);
> >     byte = pci_read_byte(dev, 0x8c);
> >     byte |= 0xff;           /* 1M */
> >     pci_write_byte(dev, 0x8c, byte);
> >     word = pci_read_word(dev, 0x90);
> >     word |= 0x7fff;         /* 15M */
>                                  ^^^
>
> Shouldn't that be 16M?
> >     pci_write_word(dev, 0x90, word);

Yes and yes.

--Ed