Re: [coreboot] [PATCH] put coreboot table in high tables area

[Stefan Reinauer]

On 16.03.2009 23:50 Uhr, Peter Stuge wrote:
> Stefan Reinauer wrote:
> > This patch adds "high coreboot table support" to coreboot version 2.
>
> I like it.
> > This patch also adds "table forward" support to flashrom and
> > nvramtool.
>
> The additions to flashrom aren't super clean. Please change the
> variable name low_1MB now that it doesn't always map to the low 1MB.
> Also please make the find_lb_table() call use the new #define instead
> of hardcoded 1024*1024 since it was substituted everywhere else.
> > if (!lb_table)
> >    	lb_table = find_lb_table(low_1MB, 0xf0000, 1024*1024);
>
> (This call.)
>
> Please fix that, then it's:
>
> Acked-by: Peter Stuge

Thanks a lot!

Fixed the issues, and committed as 4011-4013