On Sat, Mar 16, 2019 at 9:41 AM Patrick Georgi pgeorgi@google.com wrote: o Huber nico.h@gmx.de schrieb am Sa., 16. März 2019, 16:32:
Do we want to enforce a single editor / IDE + configuration for coreboot contributions?
we don't want to lock out, e.g., sublime, emacs, and vscode users, so no.
Do we want to enforce a single tool, e.g. clang-format, that does the job for us after editing a source file?
If we go for strict coding style adherence requirements that would avoid having to manually review for coding style, which means less talking about it, which in my book is a plus.
This is the direction most new projects in modern languages are taking. clang-fmt can do this for older languages like C and I think it makes the most sense.
Do we want a combination of such a tool and check-patch?
checkpatch can't do what it wants to do, i.e. parse C with REs, and so we get 5000 lines of Perl RE code chock full of false positives. So I'd prefer not.
More generally speaking, I don't care on what we agree here, I just don't want to hear about that crap anymore, so please let's agree on something.
yeah.
It's easy. Hand it all off to an automated formatter, don't insist on manual overrides for individual personal preferences, and, above all:
--> accept that the code will not always look the way you think it should look.
This is the part people get stuck on.
ron