Re: [coreboot] [PATCH] more Kconfig default fixes

[Carl-Daniel Hailfinger]

On 10.10.2009 20:08, Stefan Reinauer wrote:
> Carl-Daniel Hailfinger wrote:
> > On 10.10.2009 11:16, Stefan Reinauer wrote:
> > > Myles Watson schrieb:
> > > > Fix AP_CODE_IN_CAR (only selected for two boards), STACK_SIZE, and
> > > > HEAP_SIZE.
> > > >
> > > > Signed-off-by: Myles Watson
> > > >
> > > > At this point my Tyan s2895 is happy with Kconfig.  Boot tested.
> > > >
> > > > Thanks,
> > > > Myles
> > >
> > > Looks (almost) good to me but I'd prefer someone else to check it, to.
> > >
> > > One thing though: We're using lzma per default now if we're using
> > > compression. This means each board needs at _least_ a stack size of
> > > 0x8000.
> > >
> > > Those boards with STACK_SIZE being 0x2000 or 0x8000 are definitely
> > > broken (and if they boot, they do by accident)
> >
> > And the current infrastructure means we need that stack size per core if
> > any of the APs perform any decompression (which is a bad idea in itself).
>
> Which systems do that? we should fix them...

AFAIK the Fam10 targets Zheng is having problems with.

Regards,
Carl-Daniel