Pattrick Hueper wrote:
Ok, i will change the Kconfig name and the directory.
I would not like to change the filename biosemu.c cause that makes merging with the slof.git harder. Would that be ok?
If that file is effectively the entire work, then I think it could definately have the same name as the project/repo/directory.
On the other hand, it is of course expected to have descriptive file names, which makes biosemu.c a good name for a file doing BIOS emulation in any case.
However - would it not be desirable to unify enough code so that you can use the same repo both for SLOF and coreboot?
One more thing... YABEL currently needs 1MB of memory for its "virtual" memory to store INT Vectors, ROM Image, ... it is currently hard coded to 16MB, should i move this to Kconfig as well and what would be a good default location?
It could go into Kconfig but users should not be bothered with it. Maybe make it changeable for experts only.
Or implement an algorithm in code that looks at available memory and navigates around any reserved areas. I like that better.
//Peter