* Segher Boessenkool email@example.com [070210 20:13]:
Signed-off-by means "I am (in part) responsible for this ending up in thid repo", i.e., you wrote part of the patch or you were on the path pushing it in.
Acked-by is used as a comment "looks fine by me" when not taking direct action yourself.
Does commiting constitute "on the path pushing it in" ?
Yes. Read the DCO if you're still unsure :-)
DCO? Is that an abbreviation for http://www.linuxbios.org/Development_Guidelines?
Ie. if I review and then commit, should I sign off or ack?
I would say ack, but not necessarily sign off.