Re: [coreboot] [PATCH 2/7] ASUS M2V support (v2): VT8237A LPC device id (unchanged)

[Rudolf Marek]

Hi,

I think following is not true. The VT8237A has something else at 0x50, so 
vt8237_sb_enable_fid_vid should not be neccessary to call. Do you call it or 
not? If not then we either need to fix it for the "old" location 0x11 iirc or 
not to put there any test for A version.
> +static const struct device_operations vt8237r_lpc_ops_a = {
> .read_resources		= vt8237r_read_resources,
> .set_resources		= pci_dev_set_resources,
> .enable_resources	= pci_dev_enable_resources,
> .init			= vt8237r_init,
> .scan_bus		= scan_static_bus,
>
> +};

I think you dont need this for now, if you use "r" init version you can cange it 
directly:
> +static const struct pci_driver lpc_driver_a __pci_driver = {
> .ops	=&vt8237r_lpc_ops_a,

_r here.

Thanks,
Rudolf