Re: [coreboot] r3213 - trunk/payloads/libpayload/include

[Carl-Daniel Hailfinger]

On 04.04.2008 22:08, Segher Boessenkool wrote:
> > +#define BIN2HEX(b) ("0123456789abcdef"[b & 15])
> > +#define HEX2BIN(h) (('0' <= h && h <= '9') ? (h - '0') : \
> >                ('a' <= h && h <= 'f') ? (h - 'a' + 10) : 0)
>
> These macros are unsafe: lack of parentheses around the uses of
> the parameters, and multiple evaluation in the second macro.
>
> Please consider using an inline function instead (or a "real"
> function, to make code size smaller).
>
> Btw, could the SVN checkin list be set up with a followup-to: header?

Could we please change the Followup-To (standardized for newsgroups
only) to Reply-To (standardized for mail)?

Thanks.
Carl-Daniel