Re: [coreboot] r3818 build service

[Myles Watson]

> > Index: src/mainboard/asus/m2v-mx_se/Options.lb
> >
> > --- src/mainboard/asus/m2v-mx_se/Options.lb     (revision 3820)
> > +++ src/mainboard/asus/m2v-mx_se/Options.lb     (working copy)
> > @@ -96,7 +96,7 @@
> >  default ROM_SIZE = 512 * 1024
> >  default FALLBACK_SIZE = 256 * 1024
> >  default HAVE_FALLBACK_BOOT = 1
> > -default HAVE_HARD_RESET = 0
> > +default HAVE_HARD_RESET = 1
> >  default HAVE_PIRQ_TABLE = 0
> >  default IRQ_SLOT_COUNT = 11    # FIXME?
> >  default HAVE_MP_TABLE = 1
> > Index: src/mainboard/asus/m2v-mx_se/cache_as_ram_auto.c
> > ===================================================================
> > --- src/mainboard/asus/m2v-mx_se/cache_as_ram_auto.c    (revision 3820)
> > +++ src/mainboard/asus/m2v-mx_se/cache_as_ram_auto.c    (working copy)
> > @@ -126,6 +126,7 @@
> >  {
> >  }
> >
> > +#warning No hard_reset implemented for this board!
> >  void hard_reset(void)
> >  {
> >         print_info("NO HARD RESET. FIX ME!\n");
> >
> > This patch fixes the build for asus/m2v-mx_se.  Its hard_reset function
>
> is
> > not
> > implemented (It just prints "hard_reset not implemented.  FIX ME!" This
> > patch
> > defines HAVE_HARD_RESET 1 and adds a #warning hard_reset not
>
> implemented.
> > The net effect is that hard_reset prints something instead of just
>
> entering
> > an
> > infinite loop.
> >
> > Signed-off-by: Myles Watson
>
> Agreed.
> Acked-by: Marc Jones

Rev 3823.

Thanks,
Myles