Re: [coreboot] v3 compilation failures

[Marc Jones]

ron minnich wrote:
> On Jan 21, 2008 1:14 PM, Marc Jones  wrote:
> > --- LinuxBIOSv3.orig/include/lib.h      2008-01-11 15:52:52.000000000 -0700
> > +++ LinuxBIOSv3/include/lib.h   2008-01-11 16:04:12.000000000 -0700
> > @@ -36,11 +36,4 @@
> >  void beep_short(void);
> >  void beep_long(void);
> >
> > -/* smbus functions */
> > -int smbus_read_byte(unsigned device, unsigned address);
>
> hmm. So where does the prototype live then?
> > -/* dram functions */
> > -void ram_failure(const char *why);
> > -void ram_initialize(int controllers, void *ctrl);
>
> These are in lib/ram.c and even defined in the documentation ;-)
>
> What should we do about that?

You have a point. There should be a standard prototype but lib.h seemed 
to be a random place for them.

Marc