[coreboot] Re: compiler/toolchain issue?

[Patrick Georgi]

Hey Mike,

 schrieb am Fr., 14. Juni 2019, 22:12:
> Please make sure you have the correct access rights
>    and the repository exists.
>    Clone of
> 'ssh://review-android.quicinc.com:29418/coreboot/chrome-ec.git' into
> submodule path '3rdparty/chromeec' failed

These are because we use relative paths for the submodules. The idea is
that mirrors also mirror the submodules and everything is then loaded from
the same location.

Chrome EC should be no problem, but coreboot relies on the vboot submodule
these days which is imported the same way.

And here is tail-end of coreboot build that fails:

HOSTCC     cbfstool/cbfstool.o
> In file included from <command-line>:0:0:
> /local/mnt/workspace/mturney/gitrepos/qualcomm/chromebook/cbdc-meta/standalone/coreboot/util/cbfstool/cbfstool.c:
>
> In function 'cbfs_add_component':
> /local/mnt/workspace/mturney/gitrepos/qualcomm/chromebook/cbdc-meta/standalone/coreboot/src/commonlib/include/commonlib/compiler.h:59:2:
>
> error: first argument to '__builtin_choose_expr' not a constant
>    __builtin_choose_expr(__builtin_constant_p(expr), fallback_expr,
> expr))
>    ^
> /local/mnt/workspace/mturney/gitrepos/qualcomm/chromebook/cbdc-meta/standalone/coreboot/src/commonlib/include/commonlib/helpers.h:39:2:
>
> note: in expansion of macro '__TYPEOF_UNLESS_CONST'
>    __TYPEOF_UNLESS_CONST(a, b) var_a = (a); \
>    ^
> /local/mnt/workspace/mturney/gitrepos/qualcomm/chromebook/cbdc-meta/standalone/coreboot/src/commonlib/include/commonlib/helpers.h:49:26:
>
> note: in expansion of macro '__CMP_SAFE'
>    __CMP_UNSAFE(a, b, op), __CMP_SAFE(a, b, op, __TMPNAME, __TMPNAME))
>                            ^
> /local/mnt/workspace/mturney/gitrepos/qualcomm/chromebook/cbdc-meta/standalone/coreboot/src/commonlib/include/commonlib/helpers.h:56:19:
>
> note: in expansion of macro '__CMP'
>   #define MAX(a, b) __CMP(a, b, >)
>                     ^
> /local/mnt/workspace/mturney/gitrepos/qualcomm/chromebook/cbdc-meta/standalone/coreboot/util/cbfstool/cbfstool.c:546:19:
>
> note: in expansion of macro 'MAX'
>     uint32_t size = MAX(hs, param.padding);

This is built with your host compiler. Probably an old compiler?

Patrick