Re: [LinuxBIOS] [PATCH] Flashrom: sis630 simplification

[Peter Stuge]

On Sat, Sep 08, 2007 at 07:56:32PM +0200, Uwe Hermann wrote:
> On Sat, Sep 08, 2007 at 04:49:46PM +0200, Alex Beregszaszi wrote:
> > attached patch changes out/in combinations to pci_read/write_byte in
> > sis630 chipset enable.
>
> Why?

There is abstraction available - so it should be used everywhere.
> Did you test the patch on hardware?

On Sat, Sep 08, 2007 at 10:59:39AM -0700, ron minnich wrote:
> I don't think this should be done unless someone can test.

I agree with the patch - I want the change, but I also agree it would
be nice to have it tested.

We could argue that we decided to go through with the patch in order
to improve the code and until someone has a problem with the code not
working there is no real problem.

//Peter