[Sorry for being late, I'm a bit, um... Internet-challenged at the moment. No PGP signature for the same reason.]
On Wed, Sep 26, 2007 at 11:50:52AM +0200, Robert Millan wrote:
On Tue, Sep 25, 2007 at 03:53:21PM -0700, ron minnich wrote:
Robert, I understand the reason for the include of the .c files, but go ahead and just copy the code. We've tried both ways, over the years, and it's better to clone the code, since the vendors have a habit of changing things on mainboards, and code that includes other code can cause trouble in both directions.
I strongly disagree with this approach. Duplicated code is bad, bad, bad and should be avoided whereever possible.
Now, in order to not only complain, here's a demo patch which completely avoids copying a single file. One code base for the
- ASUS A8N-E - ASUS A8N5X - ASUS A8NE-FM/S (I'll send an extra patch for that later)
No duplicated code whatsoever. Sure, this may not be too elegant (there's some room for improvements, though), but it's definately a _lot_ better than duplicating all those files.
This is (manually) build-tested for the A8N-E and A8N5X and worked for me. I did not test the produced ROMs, though.
In addition to the patch, you need to create a symlink src/mainboard/asus/a8n_e -> src/mainboard/asus/a8n5x in order to make the build system happy.
Uwe.