On Mon, Oct 04, 2010 at 05:48:03PM +0200, Patrick Georgi wrote:
Hi,
attached patch removes several "#include *.c" from romstage.c in i945 based boards and moves those files to romstage-srcs instead (ie. separate compilation units).
There's one global change, the removal of ramtest.c from CAR romstage.cs
It's abuild tested and boot tested on kontron/986lcd-m. Probably should be tested (so that ramtest.c stuff is a separate patch), but the global changes were actually the last change I made.
Signed-off-by: Patrick Georgi patrick.georgi@coresystems.de
Looks good.
Acked-by: Uwe Hermann uwe@hermann-uwe.de
There's one small warning e.g. on kontron/986lcd-m: Makefile:261: warning: overriding commands for target `build/cpu/x86/name/name.ramstage.o' Makefile:261: warning: ignoring old commands for target `build/cpu/x86/name/name.ramstage.o'
Also, building with Debug Port support breaks, but should be simple to fix, it's just a missing prototype or #include I think:
cc1: warnings being treated as errors src/mainboard/kontron/986lcd-m/romstage.c: In function ‘main’: src/mainboard/kontron/986lcd-m/romstage.c:352: error: implicit declaration of function ‘i82801gx_enable_usbdebug’ src/mainboard/kontron/986lcd-m/romstage.c:353: error: implicit declaration of function ‘early_usbdebug_init’ make: *** [build/mainboard/kontron/986lcd-m/romstage.pre.inc] Error 1
Uwe.