On 05.01.2008 17:42, Torsten Duwe wrote:
Here's the full story, which I'm hoping to address all related problems with. We agreed that a VGA console and the need to run any option ROMs is mutually not strictly dependent, Luc's problem was that LBv2 code doesn't reflect that. There are 6 combinations:
- Console may be on VGA or not (e.g. serial)
_independently_
- LB might run
- no option ROMs
- only VGA option ROMs
- all option ROMs
I'm missing the "all option ROMs except VGA" choice for machines with a native video driver/init and some plugged-in SCSI cards.
The combination "no option ROMs" / "VGA console" currently does not compile; Ron fixed that.
I would now additionally introduce CONFIG_VGA_ROM_RUN, to map all 6 combinations. The implicit (broken) assumption that CONSOLE_VGA would also run the ROMs is lifted, and transferred to this new config option instead; the source code becomes less ambiguous.
Agreed. How about an additional CONFIG_NONVGA_ROM_RUN?
This change is minimally intrusive, because all board configs that previously assumed CONSOLE_VGA would also run the ROMs didn't compile, they had to also specify PCI_ROM_RUN, so this new option only offers 2 new opportunities which didn't work before or were impossible to specify, respectively.
This part combines Luc's and Ron's patches, and adds the new option to clarify.
Signed-off-by: Torsten Duwe duwe@lst.de
This is a good start. I assume you have tested it with abuild. Please try to get another ack from Ron or Luc as well.
Acked-by: Carl-Daniel Hailfinger c-d.hailfinger.devel.2006@gmx.net
Regards, Carl-Daniel