Re: [coreboot] v2[PATCH]RCA RM4100 i82830 support

[Peter Stuge]

On Mon, Feb 25, 2008 at 10:18:01PM -0500, Corey Osgood wrote:
> > if ((sz.side2 != 0) && (sz.side1 != sz.side2)) {
> > print_err("This board only supports\r\n");
> > print_err("symmetrical dual-sided DIMMs\r\n");
> > die("HALT\r\n");
> > }
>
> This should be moved right into the detection routine. If the
> northbridge can't handle it, then just die if sz.side1 |= sz.side2.
> The other option is to set sz.side2 to 0, and try to use it like a
> single-sided dimm.

Degrading like this with a very loud message would be a very cool
feature.
> > 		drb1 = sz.side1 >> 5;
>
> Please don't use bitwise shifts for multiplication/division, same
> applies for other places.

+1

//Peter