On Tue, Oct 12, 2010 at 11:41:24PM -0400, Keith Hui wrote:
Attached patch adds support for Katmai Slot 1 CPUs (model_67x). abuild-tested. Boot tested on P2B-LS.
Signed-off-by: Keith Hui buurin@gmail.com
Thanks, r5950 with some small whitespace changes.
I also dropped the name.o from Makefile.inc, the functions provided there are not (yet?) used in model_67x I think.
Also, you added 671 as CPU ID to model_67x which was not in there yet. Can you point me to the document where this one is listed, so we can reference it in a code comment?
As we already know the L2 patch is a huge chunk of code, so let's figure out where best to place that code. It is specific to 63x,65x and 67x CPUs. There are some small code path differences between these CPU families. I'm trying to minimize duplication;
Yep.
if these code can be put in one .c file and be linked from a few other places, that's how I'd prefer it.
Yes, that would be great.
Uwe.