Re: [coreboot] Coreboot-v2 patch rom names

[Myles Watson]

> -----Original Message-----
> From: Ward Vandewege [mailto:[e-mail]]
> Sent: Wednesday, February 06, 2008 11:34 AM
> To: Myles Watson
> Cc: Coreboot
> Subject: Re: [coreboot] Coreboot-v2 patch rom names
>
> On Tue, Feb 05, 2008 at 02:20:06PM -0700, Myles Watson wrote:
> > This patch changes all rom names that aren't coreboot.rom in Config.lb
>
> files.
> > I think that since the directory specifies the architecture and the
> > board, it is redundant information to name it something else, and it
> > makes it more difficult to automate the build process (buildrom).
>
> Great.
> > In buildrom we should just use Config-options.lb files instead of
> > patching or keeping our own.  It just adds more to maintain, with very
> > little benefit.  The correct place for Config.lb files is in the
> > coreboot-v2 tree.
> >
> > The next patch would add Config-lab.lb files for each architecture
> > supported by buildrom.
>
> That would work - but what about other payloads? Maybe we could use a
> naming
> scheme like
>
> Config-buildrom-$(PAYLOAD).lb
>
> and then make buildrom look for such a file, perhaps falling back to the
> generic Config.lb file if it does not exist?

That could work.  Right now the Config-lab.lb for each architecture is a
fallback image with compression enabled.  Maybe Config-lab.lb is not the
right name.  Any payload that doesn't use compression will need to use the
Config.lb, and any payload that uses compression should use Config-lab.lb

In some cases the ROM size is larger for the Config-lab.lb as well.

I thought about naming them Config-ROM_SIZE-COMPRESSION.lb:
    Config-1M-lzma.lb or 
    Config-512K-none.lb

But it seemed uglier.

The two attached patches implement the switch, the buildrom patch depends on
the Coreboot patch being applied first to create a revision 3091.  I tested
it by not updating the revision, then manually doing "svn up", applying the
patch to Coreboot, and rebuilding.

There is a lot of cleaning up that could be done in the Config.lb files, but
I only touched the ones that buildrom uses, so I wouldn't break anything
else.

Suggestions are welcome.

Myles

Signed-off-by: Myles Watson
> Thanks,
> Ward.