The X86_GOOD_APIC was set in the past in a few configs. You can find them via:
git log -S GOOD_APIC --source --all
The define itself was finally removed in:
commit fc57d6c4c2848726be1361f6dee3c33e7551b857 Author: Patrick Rudolph siro@das-labor.org Date: Tue Nov 12 16:30:14 2019 +0100
cpu/x86/lapic: Support x86_64 and clean up code
From then on all APICs were "bad".
But it looks like the workaround was just carried forward with no discussion of whether it's still necessary or what it actually works around.
Julian
On Mon, 2021-10-04 at 09:41 -0700, ron minnich wrote:
I would be happy if all those old buggy systems were gone, good idea Peter!
On Mon, Oct 4, 2021 at 9:39 AM Peter Stuge peter@stuge.se wrote:
ron minnich wrote:
The problem, at this point, is that a change this broad must also be tested across all platforms to make sure it's not breaking.
While true it could be worthwhile to check how often CONFIG_X86_GOOD_APIC is unset...
This looks like it was done for a hardware problem. We had a lot of x86 implementations in tree at that time, and they had lots of bugs.
Maybe none of them are left.
//Peter _______________________________________________ coreboot mailing list -- coreboot@coreboot.org To unsubscribe send an email to coreboot-leave@coreboot.org
coreboot mailing list -- coreboot@coreboot.org To unsubscribe send an email to coreboot-leave@coreboot.org