Hi Carl-Daniel, How about this?
Signed-off-by: mxie Michael.xie@amd.com
Thank you.
-----Original Message----- From: Carl-Daniel Hailfinger [mailto:c-d.hailfinger.devel.2006@gmx.net] Sent: Wednesday, September 17, 2008 10:18 AM To: Xie, Michael Cc: coreboot@coreboot.org Subject: Re: [coreboot] the patch for AMD S1G1 processor socket
Dear Michael,
thank you for these patches.
Would it be possible for you to regenerate the S1G1 CPU patch as unified diff (instead of context diff)? That makes the diff easier to read for us.
The S1G1 RAM init patch looks good. There are a few small things (copyright notice, whitespace) which may need changes, but I'm sure we can merge that patch soon.
Please add your signed-off-by line to the mail with the patches. See http://www.coreboot.org/Development_Guidelines#Sign-off_Procedure for details.
Regards, Carl-Daniel