Jordan Crouse wrote:
- unify keycodes for non-ASCII keys by using curses' codes and labels
- fix ctrl-[a-z]
- get rid of curses' ps/2 driver. uses generic one instead
- #ifdef's around ps/2 keyboard handling and serial handling
Signed-off-by: Patrick Georgi patrick.georgi@coresystems.de
Ohh - coresystems vs coresystems patch war! :)
:-) Our research and development department is working with high pressure. Once the problem was found the quick fix was the first iteration.
I prefer the merged driver, but since I haven't tested either, I would rather that the more stable of the two patches get committed if there is an immediate bug to fix.
We tested this internally with FILO which makes heavy use of CTRL-sequences and cursor keys, and I am confident that the merged driver is the way to go. It does a good job here, and if further bugs might appear, it will make things easier because we only need to fix them in one place.
Though it reduces the code, it makes the keyboard lookup tables bigger since we have to store shorts instead of chars for that for each character.
I vote in favor of dropping my first patch and use Patricks much better version.
Stefan