On Sun, Feb 10, 2019 at 10:46 PM Zeh, Werner werner.zeh@siemens.com wrote:
Hi Ron.
For me the reason of decreasing the log level is boot time and not flash size.
Werner, this is a good reason to ensure that debug messages can be turned off. This is why coreboot has console loglevel controls.
So it makes sense to be able to control the log level, no question. I'm not arguing that.
What I'm saying is that the concept of a 'debug build', which seems to derive from windows practice (I'm not kidding!), is a bad idea for FSP. There should not be a debug build. There should always be one build, not least because sometimes debug builds can fail in odd ways at build or boot time, due to design or programming errors. I've seen this in practice in UEFI, where enabling debug messages breaks the UEFI build.
FSP should create a single build with a tunable console print level. I am hoping someone from Intel will take note.
IMHO debug builds are a bad idea.