On Fri, 20 Jun 2008 11:21:50 +0800, "Zhang Rui" zrfail@gmail.com wrote:
2008/6/20 Joseph Smith joe@settoplinux.org:
I don't think so, I am excited to try it out once you are finished. Although I am using IDE instead of SCSI. Sorry if I sound like a broken record, the main thing to remember is we need to make all the LegacyBIOS code that is getting injected into the coreboot base code optional, hence the "if option LegacyBIOS is
selected".
There are alot of people sensative about this, and we need to keep
coreboot
flexible and make everyone happy, right?
OK, I will keep "making LegacyBIOS code optional" in my mind. May be a choice in the menuconfig is suitable? I will implement this option after I finished the SCSI booting functionality. Is this OK?
Sure
For v3 you could probably just use the menuconfig. I haven't played around with v3 yet, so someone else would probably be better to answer that.
For v2 use a global option in Option.lb, something like:
uses USE_LEGACYBIOS ## ## Build code for LegacyBIOS support ## 0 = disabled, 1 = enabled ## default USE_LEGACYBIOS = 1
and then before and after your code use a preprocessing directive:
#if USE_LEGACYBIOS
Insert LegacyBIOS code here
#endif
And another question, LegacyBIOS is not in the coreboot base code now and where should we put it? Maybe in the util/LegacyBIOS?
This would be a good question for Kevin
Hope that helps:-)