Nico Huber wrote:
So, it's wrong but not broken
..yet
What do you think? Should we allow such changes?
I think yes.
Should we normalize on any style?
There is an argument to be made for allowing many different styles, but I think it would be wise to standardize.
my personal preference would be `1u << 31`.
That looks nicer, but based purely on my limited experience with C source code seems a lot less common than UL. Are there any relevant compatibility matters known, for the different suffixes?
I don't hate BIT(31) but I strongly prefer BIT31, which I use always because it's short and sweet; easy to type and read.
Macros also have the significant benefit of moving the definition into a single place, which for one prevents future omission mistakes.
//Peter