Re: [coreboot] [PATCH] YABEL compilation warnings

[Stefan Reinauer]

On 3/5/10 4:13 PM, Myles Watson wrote:
> I think we should get rid of that warning, since we conditionally
> call functions based on debugging and various config variables.  

I think we should instead just drop CONFIG_WARNINGS_ARE_ERRORS for Qemu
rather than dropping warnings. Or maybe only add -Wno-unused-function if
CONFIG_WARNINGS_ARE_ERRORS is active, at least.  Or maybe add an Option
"Warnings good for Developers"?
> Is there a case where it helps enough to justify all the warnings?

Yes, they indicate that there is dead code. This is, not only but
especially useful to recognize if / how code should / could be restructured.
> Signed-off-by: Myles Watson <[e-mail]
> >

With the -Wno-unused-functions taken care of:

Acked-by: Stefan Reinauer