Re: [LinuxBIOS] [PATCH] improved SPI flash support (restructured)

[Stefan Reinauer]

Carl-Daniel Hailfinger wrote:
> > > +int probe_spi(struct flashchip *flash)
> > > +{
> > > unsigned char readarr[3];
> >
> > This should be a struct imho
> >
> > typedef struct spi_id {
> >         unsigned char vendor_id;
> >         unsigned short device_id;
> > } spi_id_t;
>
> Yes, but the underlying generic SPI function uses an array for commands
> and results. Once I add write/erase support, it will become obvious why
> I used unsigned char arrays.

Ah, so maybe it should be a union?
> > what about the other SPI commands?
>
> Will be implemented once this patch has been tested.

Cool. I'll wait.