Author: uwe Date: Mon Sep 27 20:03:18 2010 New Revision: 5860 URL: https://tracker.coreboot.org/trac/coreboot/changeset/5860
Log: Add a kconfig option to allow the user to select a specific physical USB port for use as Debug Port (on chipsets which support that).
Signed-off-by: Uwe Hermann uwe@hermann-uwe.de Acked-by: Stefan Reinauer stepan@coresystems.de
Modified: trunk/src/console/Kconfig trunk/src/mainboard/gigabyte/ga_2761gxdk/romstage.c trunk/src/mainboard/gigabyte/m57sli/romstage.c trunk/src/mainboard/msi/ms7260/romstage.c trunk/src/mainboard/msi/ms9652_fam10/romstage.c trunk/src/mainboard/nvidia/l1_2pvv/romstage.c trunk/src/mainboard/tyan/s2912/romstage.c trunk/src/mainboard/tyan/s2912_fam10/romstage.c
Modified: trunk/src/console/Kconfig ============================================================================== --- trunk/src/console/Kconfig Mon Sep 27 19:53:17 2010 (r5859) +++ trunk/src/console/Kconfig Mon Sep 27 20:03:18 2010 (r5860) @@ -112,6 +112,27 @@
If unsure, say N.
+# Note: This option doesn't make sense on Intel ICH southbridges as those +# hardcode the physical USB port to be used as Debug Port to 1. It cannot +# be changed by coreboot. +config USBDEBUG_DEFAULT_PORT + int "Default USB port to use as Debug Port" + default 1 + depends on USBDEBUG && !SOUTHBRIDGE_INTEL_I82801GX + help + This option selects which physical USB port coreboot will try to + use as EHCI Debug Port first (valid values are: 1-15). + + If coreboot doesn't detect an EHCI Debug Port dongle on this port, + it will try all the other ports one after the other. This will take + a few seconds of time though, and thus slow down the booting process. + + Hence, if you select the correct port here, you can speed up + your boot time. Which USB port number (1-15) refers to which + actual port on your mainboard (potentially also USB pin headers + on your mainboard) is highly board-specific, and you'll likely + have to find out by trial-and-error. + config CONSOLE_VGA bool "Use VGA console once initialized" default n
Modified: trunk/src/mainboard/gigabyte/ga_2761gxdk/romstage.c ============================================================================== --- trunk/src/mainboard/gigabyte/ga_2761gxdk/romstage.c Mon Sep 27 19:53:17 2010 (r5859) +++ trunk/src/mainboard/gigabyte/ga_2761gxdk/romstage.c Mon Sep 27 20:03:18 2010 (r5860) @@ -40,8 +40,6 @@ #define K8_REV_F_SUPPORT_F0_F1_WORKAROUND 0 #endif
-#define DBGP_DEFAULT 7 - #include <stdint.h> #include <string.h> #include <device/pci_def.h> @@ -196,7 +194,7 @@ report_bist_failure(bist);
#if CONFIG_USBDEBUG - sis966_enable_usbdebug(DBGP_DEFAULT); + sis966_enable_usbdebug(CONFIG_USBDEBUG_DEFAULT_PORT); early_usbdebug_init(); #endif console_init();
Modified: trunk/src/mainboard/gigabyte/m57sli/romstage.c ============================================================================== --- trunk/src/mainboard/gigabyte/m57sli/romstage.c Mon Sep 27 19:53:17 2010 (r5859) +++ trunk/src/mainboard/gigabyte/m57sli/romstage.c Mon Sep 27 20:03:18 2010 (r5860) @@ -38,8 +38,6 @@ #define K8_REV_F_SUPPORT_F0_F1_WORKAROUND 0 #endif
-#define DBGP_DEFAULT 7 - #include <stdint.h> #include <string.h> #include <device/pci_def.h> @@ -212,7 +210,7 @@ report_bist_failure(bist);
#if CONFIG_USBDEBUG - mcp55_enable_usbdebug(DBGP_DEFAULT); + mcp55_enable_usbdebug(CONFIG_USBDEBUG_DEFAULT_PORT); early_usbdebug_init(); #endif console_init();
Modified: trunk/src/mainboard/msi/ms7260/romstage.c ============================================================================== --- trunk/src/mainboard/msi/ms7260/romstage.c Mon Sep 27 19:53:17 2010 (r5859) +++ trunk/src/mainboard/msi/ms7260/romstage.c Mon Sep 27 20:03:18 2010 (r5860) @@ -42,8 +42,6 @@ #define K8_REV_F_SUPPORT_F0_F1_WORKAROUND 0 #endif
-#define DBGP_DEFAULT 7 - #include <stdint.h> #include <string.h> #include <device/pci_def.h> @@ -181,7 +179,7 @@ uart_init(); report_bist_failure(bist); /* Halt upon BIST failure. */ #if CONFIG_USBDEBUG - mcp55_enable_usbdebug(DBGP_DEFAULT); + mcp55_enable_usbdebug(CONFIG_USBDEBUG_DEFAULT_PORT); early_usbdebug_init(); #endif console_init();
Modified: trunk/src/mainboard/msi/ms9652_fam10/romstage.c ============================================================================== --- trunk/src/mainboard/msi/ms9652_fam10/romstage.c Mon Sep 27 19:53:17 2010 (r5859) +++ trunk/src/mainboard/msi/ms9652_fam10/romstage.c Mon Sep 27 20:03:18 2010 (r5860) @@ -33,8 +33,6 @@ #define SET_FIDVID 1 #define SET_FIDVID_CORE_RANGE 0
-#define DBGP_DEFAULT 7 - #include <stdint.h> #include <string.h> #include <device/pci_def.h> @@ -185,7 +183,7 @@ report_bist_failure(bist);
#if CONFIG_USBDEBUG - mcp55_enable_usbdebug(DBGP_DEFAULT); + mcp55_enable_usbdebug(CONFIG_USBDEBUG_DEFAULT_PORT); early_usbdebug_init(); #endif
Modified: trunk/src/mainboard/nvidia/l1_2pvv/romstage.c ============================================================================== --- trunk/src/mainboard/nvidia/l1_2pvv/romstage.c Mon Sep 27 19:53:17 2010 (r5859) +++ trunk/src/mainboard/nvidia/l1_2pvv/romstage.c Mon Sep 27 20:03:18 2010 (r5860) @@ -38,8 +38,6 @@ #define K8_REV_F_SUPPORT_F0_F1_WORKAROUND 0 #endif
-#define DBGP_DEFAULT 7 - #include <stdint.h> #include <string.h> #include <device/pci_def.h> @@ -198,7 +196,7 @@ report_bist_failure(bist);
#if CONFIG_USBDEBUG - mcp55_enable_usbdebug(DBGP_DEFAULT); + mcp55_enable_usbdebug(CONFIG_USBDEBUG_DEFAULT_PORT); early_usbdebug_init(); #endif console_init();
Modified: trunk/src/mainboard/tyan/s2912/romstage.c ============================================================================== --- trunk/src/mainboard/tyan/s2912/romstage.c Mon Sep 27 19:53:17 2010 (r5859) +++ trunk/src/mainboard/tyan/s2912/romstage.c Mon Sep 27 20:03:18 2010 (r5860) @@ -38,8 +38,6 @@ #define K8_REV_F_SUPPORT_F0_F1_WORKAROUND 0 #endif
-#define DBGP_DEFAULT 7 - #include <stdint.h> #include <string.h> #include <device/pci_def.h> @@ -192,7 +190,7 @@ report_bist_failure(bist);
#if CONFIG_USBDEBUG - mcp55_enable_usbdebug(DBGP_DEFAULT); + mcp55_enable_usbdebug(CONFIG_USBDEBUG_DEFAULT_PORT); early_usbdebug_init(); #endif console_init();
Modified: trunk/src/mainboard/tyan/s2912_fam10/romstage.c ============================================================================== --- trunk/src/mainboard/tyan/s2912_fam10/romstage.c Mon Sep 27 19:53:17 2010 (r5859) +++ trunk/src/mainboard/tyan/s2912_fam10/romstage.c Mon Sep 27 20:03:18 2010 (r5860) @@ -33,8 +33,6 @@ #define SET_FIDVID 1 #define SET_FIDVID_CORE_RANGE 0
-#define DBGP_DEFAULT 7 - #include <stdint.h> #include <string.h> #include <device/pci_def.h> @@ -180,7 +178,7 @@ report_bist_failure(bist);
#if CONFIG_USBDEBUG - mcp55_enable_usbdebug(DBGP_DEFAULT); + mcp55_enable_usbdebug(CONFIG_USBDEBUG_DEFAULT_PORT); early_usbdebug_init(); #endif