#31: Do proper checking for flash erase for SST FWH parts -----------------------------------+---------------------------------------- Reporter: stepan | Owner: stepan Type: defect | Status: assigned Priority: minor | Milestone: Enhance the flashrom utility Component: flashrom | Version: v2 Resolution: | Keywords: Due_close: MM/DD/YYYY | Include_gantt: 0 Dependencies: | Due_assign: MM/DD/YYYY Patchstatus: patch needs review | -----------------------------------+---------------------------------------- Comment (by segher):
Every patch needs review, unless it already got it, and then it's either back to the drawing table, or that patch get's checked in :-)
If total_size is indeed the size of flash that got erased, it looks good to me. But Stefan himself knows best, he should just go ahead and apply the patch if no one complains soon (like, wait for tomorrow morning or something like that).
Segher