Re: [coreboot] [PATCH] Factor out ROM size calculation from Config.lb

[Carl-Daniel Hailfinger]

On 21.04.2009 00:56, Myles Watson wrote:
> On Sun, Apr 19, 2009 at 9:26 AM, Carl-Daniel Hailfinger
>  wrote:
> > On 18.04.2009 23:56, Carl-Daniel Hailfinger wrote:
> > > On 17.04.2009 23:38, Carl-Daniel Hailfinger wrote:
> > > > Thanks to Myles' patch adding support for include statements,
> > > > refactoring Config.lb became possible.
> > > >
> > > > Factor out ROM size calculation from Config.lb.
> > > > Only targets with USE_FAILOVER_IMAGE support are part of this patch, the
> > > > other targets will come as separate patch.
> > >
> > > I have a new patch with 87 boards (with and without USE_FAILOVER_IMAGE),
> > > but it has to work around a parser bug. diffstat is
> > >  89 files changed, 209 insertions(+), 2415 deletions(-)
> > > A total of 2206 removed lines. Yay!
> >
> > Abuild works for all changed boards.
> >
> > Signed-off-by: Carl-Daniel Hailfinger
>
> I've tested serengeti for the failover portion and s2892 for the
> nofailover portion.  ldoptions are exactly the same and they both boot
> the same.
>
> Acked-by: Myles Watson

Thanks to everyone for reviewing and to Myles for testing!
Committed in r4147.

Regards,
Carl-Daniel