The patch has been tested and passed on fam10 board. I added an acked-by line to it, but I didn't review it. I didn't trace what happened in these patches and don't know what they mean. I just tested it. If it is appropriate,
Acked-by: Zheng Bao zheng.bao@amd.com
Zheng
-----Original Message----- From: Myles Watson [mailto:mylesgw@gmail.com] Sent: Tuesday, July 07, 2009 12:44 PM To: Bao, Zheng Cc: coreboot@coreboot.org Subject: RE: [coreboot] fam10 resource can not allocated.
I tested this patch. The resource can be allocated. But the kernel can
not
go. After the "Jumping to entry point...", nothing comes out. I don't
know
the cause. Do you know?
I guess fam10 code allocates a separate register for prefetchable memory. K8 doesn't. Since I didn't add IORESOURCE_BRIDGE to the prefetchable resource, anything prefetchable didn't get allocated (look for ERROR: ... not assigned messages)
Here's an updated patch. Thanks for testing.
Signed-off-by: Myles Watson mylesgw@gmail.com
The last piece of the patch isn't necessary, but it would be nice to unify the K8 and fam10 code more than they are.
Thanks, Myles