Re: [coreboot] Patch set updated for coreboot: b0cd5ca Add AMD Family 10h PH-EO support

[Paul Menzel]

Dear QuingPei,

thank you for updating the patches.

Am Dienstag, den 13.09.2011, 12:05 +0200 schrieb QingPei Wang:
> QingPei Wang ([e-mail]) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/202
>
> -gerrit
>
> commit b0cd5ca9e6a0d7d46caab6fedf491e00f70dc532
> Author: QingPei Wang 
> Date:   Tue Sep 13 18:04:22 2011 +0800
> Add AMD Family 10h PH-EO support
>
> the patch file comes from

1. Could you start sentences in the commit message body with a capital
letter please?
> src/vendorcode/amd/agesa/f12/Proc/CPU/Family/0x10/RevE
> /F10MicrocodePatch010000bf.c

2. I do not understand the commit message. What do you mean with patch
file? In this patch you are only adding a header file.
> Change-Id: If701c8a908edf1c486665d3ce4df65da0f65c802
> Signed-off-by: QingPei Wang <[e-mail]>
>
> src/cpu/amd/model_10xxx/mc_patch_010000bf.h |  165 +++++++++++++++++++++++++++
>  1 files changed, 165 insertions(+), 0 deletions(-)

[…]

Thanks,

Paul