Re: [coreboot] [PATCH] Add support for winbond w83627uhg SuperIO

[Uwe Hermann]

Hi,

On Mon, Jan 05, 2009 at 01:11:05AM -0800, Dan Lykowski wrote:
> Patch to add support for Winbond w83627uhg SuperIO.
>
> (This is my first submission. Let me know if I did it wrong.)

You got the most important thing right -- adding the Signed-off-by :)
> Signed-off-by: Dan Lykowski

Thanks, committed in r3846 with some smaller changes:

- Make all files (C) 2009 Dynon Avionics only, pretty much all of the
   contents are trivial enough so we don't have to carry around other
   (C) lines. Or there's almost no remaining code from other people
   (e.g. in superio.c), hence we don't need the other (C) lines either.

- Changed uint8_t to the short form u8, which we're slowly migrating to
   in coreboot v2 and v3.
> +static void w83627uhg_set_input_clk_sel(device_t dev, uint8_t speed_24mhz)
> +{
>    /* Set the input clock to 24 or 48 mhz. */
>    uint8_t value;
>    value = pnp_read_config( dev, 0x24 );
>    value &= ~(1<<6);
>    if(!speed_24mhz) {
>    	value |= (1<<6);
> }

Changed the coding style and indentation a bit in the code, please check

http://www.coreboot.org/Development_Guidelines#Coding_Style
  http://lxr.linux.no/linux/Documentation/CodingStyle
> Index: src/superio/winbond/w83627uhg/Config.lb
>
> --- src/superio/winbond/w83627uhg/Config.lb	(revision 0)
> +++ src/superio/winbond/w83627uhg/Config.lb	(revision 0)

Added missing license header here (and in another file which didn't
have a header).
> +static void enable_dev(device_t dev)
> +{
> pnp_enable_devices(dev, &ops,
> sizeof(pnp_dev_info)/sizeof(pnp_dev_info[0]), pnp_dev_info);

I used ARRAY_SIZE here.

Uwe.