On Thu, May 03, 2007 at 12:15:55PM -0600, Marc Jones wrote:
Index: LinuxBIOSv2/src/mainboard/amd/norwich/auto.c
--- /dev/null 1970-01-01 00:00:00.000000000 +0000 +++ LinuxBIOSv2/src/mainboard/amd/norwich/auto.c 2007-05-03 10:34:32.000000000 -0600
[...]
+#define DIMM0 0xA0 +#define DIMM1 0xA2
Are these correct? Are they used at all?
+static void main(unsigned long bist) +{
- static const struct mem_controller memctrl [] = {
{.channel0 = {(0xa<<3)|0, (0xa<<3)|1}}
The place to use them would be here instead of the '(0xa<<3)|0' I guess, but they're not used at all, correct?
Index: LinuxBIOSv2/src/mainboard/amd/norwich/cache_as_ram_auto.c
--- /dev/null 1970-01-01 00:00:00.000000000 +0000 +++ LinuxBIOSv2/src/mainboard/amd/norwich/cache_as_ram_auto.c 2007-05-03 10:34:32.000000000 -0600 +#define DIMM0 0xA0 +#define DIMM1 0xA2
Ditto.
+## +## Build code to export a CMOS option table +## +default HAVE_OPTION_TABLE=0
^^^ Not used (?), thus...
Index: LinuxBIOSv2/src/mainboard/amd/norwich/cmos.layout
--- /dev/null 1970-01-01 00:00:00.000000000 +0000 +++ LinuxBIOSv2/src/mainboard/amd/norwich/cmos.layout 2007-05-03 10:34:32.000000000 -0600
...this file is probably obsolete and can be dropped (for now).
Uwe.