On 2/4/10 12:09 PM, repository service wrote:
Author: oxygene Date: Thu Feb 4 12:08:59 2010 New Revision: 5086 URL: http://tracker.coreboot.org/trac/coreboot/changeset/5086
Log: This patch fixes the build for the dsdt.asl/dsdt.c.
Signed-off-by: Harald Gutmann harald.gutmann@gmx.net Acked-by: Patrick Georgi patrick.georgi@coresystems.de
Modified: trunk/src/mainboard/gigabyte/m57sli/Makefile.inc
Modified: trunk/src/mainboard/gigabyte/m57sli/Makefile.inc
--- trunk/src/mainboard/gigabyte/m57sli/Makefile.inc Thu Feb 4 12:05:59 2010 (r5085) +++ trunk/src/mainboard/gigabyte/m57sli/Makefile.inc Thu Feb 4 12:08:59 2010 (r5086) @@ -54,8 +54,8 @@ ifdef POST_EVALUATION
$(obj)/dsdt.c: $(src)/mainboard/$(MAINBOARDDIR)/dsdt.asl
- iasl -p $(obj)/dsdt -tc $(src)/mainboard/$(MAINBOARDDIR)/dsdt.asl
- mv $(obj)/dsdt.hex $@
- iasl -p dsdt -tc $(src)/mainboard/$(MAINBOARDDIR)/dsdt.asl
- mv dsdt.hex $@
I don't think this is good... It creates files outside of $(obj). In fact, I think we should modify all boards to use $(obj)/dsdt if they do not.
What was the problem without the patch?