Hi,
attached patch moves the CPU specific includes from src/arch/i386/Makefile.inc to the respective CPU directories.
Very nice.. this will make using CAR easier, and the code flow easier to understand
One exception is the tyan/s2735 rule, as this is a weird situation: CAR code for exactly one board. As soon as sibling boards are identified and CAR enabled, it would make sense to move that include out as well.
These boards have the same CPU socket, thus should be able to use CAR:
./src/mainboard/dell/s1850/Kconfig: select CPU_INTEL_SOCKET_MPGA604 ./src/mainboard/intel/jarrell/Kconfig: select CPU_INTEL_SOCKET_MPGA604 ./src/mainboard/intel/xe7501devkit/Kconfig: select CPU_INTEL_SOCKET_MPGA604 ./src/mainboard/supermicro/x6dai_g/Kconfig: select CPU_INTEL_SOCKET_MPGA604 ./src/mainboard/supermicro/x6dhe_g/Kconfig: select CPU_INTEL_SOCKET_MPGA604 ./src/mainboard/supermicro/x6dhe_g2/Kconfig: select CPU_INTEL_SOCKET_MPGA604 ./src/mainboard/supermicro/x6dhr_ig/Kconfig: select CPU_INTEL_SOCKET_MPGA604 ./src/mainboard/supermicro/x6dhr_ig2/Kconfig: select CPU_INTEL_SOCKET_MPGA604 ./src/mainboard/tyan/s2735/Kconfig: select CPU_INTEL_SOCKET_MPGA604
I'm glad to provide a patch to convert these boards to CAE, if it can be tested on at least one of them. So if you have a board in this list, speak up! Having 9 more boards use CAR would be really nice to have.
For now, for the increased visibility (and because I'm a bit puzzled where a good location for that file would be), I left it there.
Please put a big and fat "FIXME move to CPU_INTEL_SOCKET_MPGA604 instead" there.
The cpu/x86/car/cache_as_ram.lds is useless, so deleting it is also part of this change (not tracked in this patch)
Signed-off-by: Patrick Georgi patrick.georgi@coresystems.de
Acked-by: Stefan Reinauer stepan@coresystems.de