Re: [coreboot] patch: two bugs in the cs5536 ide code

[Stefan Reinauer]

ron minnich wrote:
> I know some people will get upset by the find_pci_device, but:
> This patch fixes a long-standing problem in the cs5536 driver, that is
> probably also in v2.
>
> The ide_init is called with the sb device but needs the IDE device,
> which is different.

Then that is the error that needs to be fixed. ide_init needs to be
called with the IDE device.
> Signed-off-by: Ronald G. Minnich

I veto. The above is against the concept of constructors we have in v3
or drivers we have in v2. If we start searching for device X in code
attached to device Y, we could as well just make a long linear piece of
code searching for all devices and stop walking over the device tree.

Stefan