Re: [coreboot] patch: dbe62

[Carl-Daniel Hailfinger]

On 29.02.2008 00:14, ron minnich wrote:
> Committed revision 624.
>
> There's only one nitpick I did not ack on. I put all your other changes in.

Thanks.
> On Thu, Feb 28, 2008 at 3:07 PM, Carl-Daniel Hailfinger
>  wrote:
> > On 28.02.2008 23:41, ron minnich wrote:
> > > +static const struct wmsr {
> > > u32 reg;
> > > struct msr  msr;
> > >
> > > +}
> >
> > Maybe split this and move the struct declaration to a header
>
> I've thought hard about this for a few years. I will let it be for
> now, it's such a simple thing and if moved to a .h it becomes one more
> 'grep for this' type struct.

The struct type already exists in include/arch/x86/msr.h:
struct msrinit {
        u32 msrnum;
        struct msr msr;
};
and it is used all over the place. It even has a nicely fitting name. 
Your choice.

Regards,
Carl-Daniel