-----Original Message----- From: coreboot-bounces@coreboot.org [mailto:coreboot-bounces@coreboot.org] On Behalf Of Ed Swierk Sent: Wednesday, May 07, 2008 5:44 PM To: coreboot@coreboot.org Subject: Re: [coreboot] [PATCH] Implement GPIO configuration options forIntel 3100 southbridge
On Wed, May 7, 2008 at 2:28 PM, Joe joe@settoplinux.org wrote:
The gpio settings very from board to board. Why not leave this up to
the
mainboard?
Some settings are board-specific but others are required by the chipset. For example the Intel 3100 datasheet says software is required to drive a handful of GPIOs in a particular way.
As long as the chipset code has to deal with GPIOs, it may as well try to abstract away some of the boilerplate code and magic values, making it easier to port to a new mainboard.
And the code already exists, so why not use it?
I guess it is just a matter of how you want to set it up. Either way works fine.
Thanks, Joseph Smith Set-Top-Linux www.settoplinux.org