Re: [coreboot] v3 patch: fix dtc to correctly parse @x values as hex, not decimal.

[ron minnich]

On Tue, Jul 29, 2008 at 12:50 PM, Peter Stuge  wrote:
> On Tue, Jul 29, 2008 at 09:21:17AM -0700, ron minnich wrote:
> > I misunderstood the dts when I wrote this code.
> > The @ values are implicitly hex. Correctly emit hex constants for
> > all cases, including the pci a,b syntax.
>
> Great patch! I just have one general thought..
> >                 fprintf(f, "\t.path = {.type=DEVICE_PATH_CPU,.u={.cpu={ .id = %s }}},\n",
> >                 fprintf(f, "\t.path = {.type=DEVICE_PATH_CPU,.u={.cpu={ .id = 0x%s }}},\n",
>
> Shouldn't dtc actually try to convert these into scalars rather than
> storing them as strings, so that errors are caught earlier and better
> error messages can be output?

yes it probably should. That's a future fix.

rest assured I won't commit this unless it includes the commit for the
dts changes.

ron