On Mon, May 05, 2008 at 05:07:45PM +0200, Carl-Daniel Hailfinger wrote:
Can we support probing for an arbitrary number of chips instead?
I think that is overly ambitious.
flashrom assumes that flash chips are top-aligned at 4GB so there will not be very many flash chips actually connected in a way that flashrom understands today.
By using an array flash[] instead of flash, flash2 and flash3 this could be done in a loop without limits on the number of detected chips.
I thought [] too, but I set a fixed size. It's simple and cheap to increase the size should there be need, and the code will deal.
What happens if there are multiple flash chips of the same technology?
If same name, then same size and at same address => larger problem.
Overall, I really like what the patch does.
Yes, me too.
Claus, can you please test the attached patch and send an Acked-by line it if it works, then I'll commit.
Thanks!
//Peter