Re: [coreboot] v3: dts and arrays

[Stefan Reinauer]

* Marc Jones  [080214 23:16]:
> > > +++ southbridge/amd/cs5536/dts    (Arbeitskopie)
> > > @@ -57,4 +57,7 @@
> > >      com2_enable = "0";
> > >      com2_address = "0x2f8";
> > >      com2_irq = "3";
> > > /* Disable unwanted virtualized PCI devices */
> > > unwanted_vpci[0] = "0";
> > >
> > > };
> >
> > I am blissfully ignorant on the topic, but the first thing I wondered:
> >
> > Should a virtual device not be disabled in the same way as a physical one?
> >
> > pci@0,0 {
> >    disabled;
> > }
> >
> > ?
> >
> > Stefan
>
> This is an interesting idea but the devices are CS5536 specific and I don't 
> think we want to make dts CS5536 aware.

Yes, that's what I think, too.

We should use the standard pci mechanism rather than extending the dts with
unwanted_vpci[]
> I think it better use the device ID rather than the device location to
> do the disable.

Yes. This would be interesting for other platforms, too.