Re: [coreboot] [PATCH] Fix infinite loop in pnp_get_ioresource()

[Alex G.]

Hi Stefan,

Thanks for the heads-up. In my case it's the MIDI device from the
W83627EHG that has the broken mask. I see no difference when not
creating the resource, so I doubt this breaks anything.

Alex

Acked-by: Alexandru Gagniuc

On 01/29/2011 01:03 AM, Stefan Reinauer wrote:
> Hi Alexandru,
>
> thanks for finding this issue. I think I ran into this before. We
> should not silently continue in this case, and not create a resource
> either. The problem is most likely caused by a faulty devicetree.cb or
> superio driver. Hence, I suggest to print an error instead. See patch.
> Can you test, please? It should tell you which device / index is
> causing the problem.
>
> Stefan
>
> On Fri, Jan 28, 2011 at 2:14 AM, Alex G.  wrote:
> > Fix an infinite loop in pnp_get_ioresource(), which freezes coreboot if
> > a rare condition arises.
> > Signed-off-by: Alexandru Gagniuc