Carl-Daniel Hailfinger wrote:
The issue is that we do not create the snapshot tarballs. We should, and part of that process would be to replace SVNDEF in Makefile.
We do provide snapshots of all repositories, but they are scattered all over the place and I can't remember where flashrom ends up.
I only find v2 and v3 at http://qa.coreboot.org/snapshots/
I agree that we need to have a page which points to all snapshots.
Either on the Download page or on each relevant page. In the Flashrom case I think it belongs on the Flashrom page.
+# Note to packagers: Any tree exported with "make export" or "make tarball" +# will not require subversion.
Do we need to say so? It think it is really intuitive that a snapshot doesn't require svn.
+export:
- @svn export . flashrom-$(VERSION)
- @sed "s/^SVNVERSION.*/SVNVERSION := $(SVNVERSION)/" Makefile >flashrom-$(VERSION)/Makefile
- @echo Exported flashrom repository contents to flashrom-$(VERSION)/
Well, it exports the working copy, which might have changes. At least add -r to the export. It would be very nice to make the rule also apply to releases while at it. Right now it adds the rev back in. I don't know how to do that very neatly however. :\
+tarball: export
- @tar cfz flashrom-$(VERSION).tar.gz flashrom-$(VERSION)/
- @echo Created tarball of repository contents at flashrom-$(VERSION).tar.gz
Again, it's not really the repo contents. With -r it is, then maybe just say Created $filename because tar and the rev are part of the filename?
.PHONY: all clean distclean dep pciutils
I think export and tarball should be added to .PHONY.
+Packaging +---------
Really in the README? Do we have INSTALL? Maybe it's time?
//Peter