Okay, its time to start re-thinking how we do -fno-stack-protector, its obvious we are constantly robbing Peter to pay Paul.
I'll look at this on Monday.
On 07/12/07 22:51 -0500, Corey Osgood wrote:
Jordan Crouse wrote:
On 07/12/07 00:06 -0500, Corey Osgood wrote:
Typo! That makes 2 mistakes this week! Are you feeling okay? :P This does look pretty good though, and the idea of having v3 in buildrom is great! I'm kicking myself now for never having used buildrom until yesterday, such a great tool. Did you ever track down the source of that __stack_chk_fail we discussed on IRC?
Autoconf is very annoying, but as the inventor of OpenEmbedded once famously said, "autoconf sucks, but at least we know how it sucks". However, no amount of autoconf knowledge will save us from projects that further abuse the already fragile scripts. In this case, we have mkelfimage committing several crimes - 1) they overwrite incoming environment variables in autoconf, thereby thwarting any possibility of us tweaking things from the ouside, and 2) they ship a version of the final configure script, which forces us to patch both the configure.ac _and_ the configure script itself, which makes this patch much, much larger then it should be. Please, all you budding developers out there - take heed. <end rant>
Okay - here is the patch against buildrom - it fixes my ills, but I need another tester before I'll consider it good.
Index: buildrom-devel/scripts/Build.settings
--- buildrom-devel.orig/scripts/Build.settings 2007-12-07 12:19:50.000000000 -0700 +++ buildrom-devel/scripts/Build.settings 2007-12-07 12:20:14.000000000 -0700 @@ -74,7 +74,7 @@ LIBS = $(STAGING_DIR)/lib/crt1.o -lc $(LIBGCC)
HOST_CC=gcc -HOST_CFLAGS= +HOST_CFLAGS=$(STACKPROTECT)
Okay, there's reason that I've left just this part of the patch. With the patch this way, mkelfimage builds (awesome, thanks!), but lzma fails:
make[1]: Leaving directory `/home/amp/linuxbios/buildrom/buildrom-devel/work/unifdef/unifdef-1.0' Building lzma... export: 4: -fno-stack-protector: bad variable name make: *** [/home/amp/linuxbios/buildrom/buildrom-devel/work/lzma/lzma-443/C/7zip/Compress/LZMA_Alone/lzma] Error 2
With quotes around $(STACKPROTECT), lzma finishes, but mkelfimage fails:
Now at patch mkelfimage-autoconf.patch export: 5: -fno-stack-protector: bad variable name make: *** [/home/amp/linuxbios/buildrom/buildrom-devel/work/mkelfimage/stamps/.configured] Error 2
Thanks a ton for this!
-Corey