Re: [LinuxBIOS] [PATCH] v3: code documentation fixes

[Carl-Daniel Hailfinger]

On 02.09.2007 18:43, Stefan Reinauer wrote:
> Carl-Daniel Hailfinger  [070830 02:05]:
> > printk(BIOS_SPEW, "%s: %s(%s) have_resources %d enabled %d\n",
> > printk(BIOS_SPEW,
> >        "%s: %s(%s) dtsname %s have_resources %d enabled %d\n",
> >   __func__, bus->dev->dtsname, dev_path(bus->dev),
>
> These kind of indent changes look rather ugly in my opinion.

This is not really an indent change, the message became 18 chars longer
so I had to either violate the 80 column limit or move the message to a
new line. I chose the second option.
> > /* TODO: Explain why we use printk here although it is impossible */
>
> What? Impossible? Why? That commend looks pretty bogus.

newboot.lyx chapter 5.3 says stage 2 phase 1 makes printk work. That
implies printk will not work before that.
> > printk(BIOS_NOTICE, console_test);

Carl-Daniel