Re: [coreboot] Sockets and DIMM_SUPPORT

[Myles Watson]

On Fri, Sep 10, 2010 at 12:18 PM, Peter Stuge  wrote:
> Myles Watson wrote:
> > Separate sockets from RAM for some sockets.
> >
> > Checked with abuild -C.
> >
> > Signed-off-by: Myles Watson
> > +++ svn/src/northbridge/amd/amdfam10/Kconfig
>
> ..
> > +config DIMM_FBDIMM
> > +config DIMM_DDR2
> > +config DIMM_DDR3
> > +config DIMM_REGISTERED
>
> Great!
> > +if DIMM_FB_DIMM
> > config DIMM_SUPPORT
> > hex
> > default 0x0110
> >
> > +endif
> >
> > +if DIMM_DDR2
> > if DIMM_REGISTERED
> > config DIMM_SUPPORT
> > hex
> > default 0x0104
> > endif
> > if !DIMM_REGISTERED
> > config DIMM_SUPPORT
> > hex
> > default 0x0004
> > endif
> >
> > +endif
>
> I'd prefer if this logic was in code rather than Kconfig though.

I agree.  I thought this was a good intermediate step.  There are some
memory types that don't seem to fit the pattern very well.  I'm not
familiar with the fam10 RAM initialization code, and didn't want to
break anything.
> Acked-by: Peter Stuge

Rev 5800.

Thanks,
Myles