On Tuesday 16 June 2009 14:18:41 Carl-Daniel Hailfinger wrote:
Hi Harald,
On 14.06.2009 16:25, Harald Gutmann wrote:
here is the new version of the fix. I cleaned out all of the stuff you mentioned.
The last point with initializing some "not existent" hardware PCI slots is as I initial did it. Discussion on that point would be good. Shall we leave it like it is in my patch, or shall we just initialize 7,8 (physically) and 10,0 for FireWire?
From my view the patch is in a good shape and was in the mean time verified by Florentin Demetrescu (partially) as working and therefore it get's the:
Signed-off-by: Harald Gutmann harald.gutmann@gmx.net
Does this fix also work on version 1.x of the board? I think Ward had problems with it.
I can't say it exactly where the problem which remains on v1 is coming from, but I think that this is not related to my patch as the DSDT.asl, which is the base information source for this patch, from v1 and v2 is exactly the same (except an address base used for something else).
If all revisions of the board work with this patch (or at least nothing gets worse), the patch is
All revisions work so far, except a little NMI problem on v1, but at least nothing gets worse with that patch.
Acked-by: Carl-Daniel Hailfinger c-d.hailfinger.devel.2006@gmx.net
Thanks, r4362.
Remember to use Luc's Ack as well if you commit.
Regards, Carl-Daniel
Kind regards, Harald