Rudolf Marek wrote:
Here is a proposed way how to handle the SATA PHY settings on SB700. It consists of weak function which always exists (with defaults) and a possibility to override this with normal function in main.c. This is the other way of doing that and not using the devictree.cb.
Please tell if it is ok this way.
I feel that having these settings in devicetree.cb is the right way<tm>, but weak functions could be an excellent step in that direction!
Weak functions would add a bit of structure currently missing when stuff is done directly in mainboard_init().
It's also much smaller changes to create the overrides than it is to evolve the internal devicetree API.
I like it.
//Peter