Hi Mike,
I probably started skipping past this thread as soon as I saw the the initial response. It failed my 0.25-second test -- sorry.
Julius is right, though. cbfstool is built with your host compiler and the older versions of gcc don't like that patch.
As I am currently stuck on using 14.04 Ubuntu which has an old version
of GCC, I am curious what gcc versions are in use that folks are using to build coreboot in standalone tree?
Although I wasn't "stuck", I didn't want to risk or take time switching away from 14.04 in the middle of an important project. I moved gcc forward only to 6.5.0 and no longer had the problem. The exact steps I used are long gone out of my history, but I probably used something like described here: https://gist.github.com/application2000/73fd6f4bf1be6600a2cf9f56315a2d91
Thanks, Marshall
On Tue, Jun 25, 2019 at 3:03 PM Julius Werner jwerner@chromium.org wrote:
Using git blame, all of the code (cbfstool & commonlib headers) was last modified 2015 and 2017, so figure it is toolchain and/or my host, which is Ubuntu 16.04.
No, the code it's choking on was actually added in April: https://review.coreboot.org/32027
I think I cherry-picked and modified a very old CL from 2015 (where I had already tried doing that once and gave up at some point) as a starting point to develop that patch, and it seems like the authoring date from that stuck around in Git, so it looks like it's from 2015 in blame. Somewhat unfortunate but can't fix it now. (Really, I'm surprised that git-blame it uses that date at all, rather than the commit date, but that's on Git.)
Someone already reported the GCC incompatibility on that patch, it requires at least GCC 6.3.0 (possibly works with 5.0 as well, don't think anybody tested that). Since the last Ubuntu LTS that comes with an older version is already out-of-support and other distros have presumably likewise been at a newer version for a while, we decided that it doesn't need fixing.
Can you deal with it locally (e.g. manually install the GCC package from 17.04)? _______________________________________________ coreboot mailing list -- coreboot@coreboot.org To unsubscribe send an email to coreboot-leave@coreboot.org